Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#173] 디스코드 훅 비동기 처리 풀 설정 #189

Merged
merged 9 commits into from
Jul 13, 2024

Conversation

belljun3395
Copy link
Collaborator

🎫 연관 이슈

resolved: #173

💁‍♂️ PR 내용

  • 디스코드 훅 비동기 처리 풀 설정

🙏 작업

  • ThreadPoolProperties를 구현해서 application.yml에 있는 thread pool 설정을 관리합니다.
  • @ConfigurationPropertiesScan 추가해서 ThreadPoolProperties를 인식할 수 있도록 합니다.
  • WorkbookSubscriptionEventListener에 설정한 DISCORD_HOOK_EVENT_POOL를 할당합니다.

thread pool 설정

discord:
    thread-pool:
        core-pool-size: 5
        max-pool-size: 15
        queue-capacity: 30
        wait-for-tasks-to-complete-on-shutdown: true
        await-termination-seconds: 60

🙈 PR 참고 사항

📸 스크린샷

🤖 테스트 체크리스트

  • 체크 미완료
  • 체크 완료

@belljun3395 belljun3395 requested a review from hun-ca as a code owner July 11, 2024 03:41
@github-actions github-actions bot added config 설정 파일과 관련된 내용을 다룰 때 사용됩니다 feature 새로운 기능을 만들 때 사용됩니다 labels Jul 11, 2024
Copy link
Member

@hun-ca hun-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

Comment on lines +10 to +15
thread-pool:
core-pool-size: 5
max-pool-size: 15
queue-capacity: 30
wait-for-tasks-to-complete-on-shutdown: true
await-termination-seconds: 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 좋습니다. 혹시 몰라서 설정 정보 메모용으로 남겨둘께요

  • core-pool-size: 풀 최소 사이즈
  • max-pool-size: 풀 최대 사이즈
  • queue-capacity: 모두 사용중일 때 기다리게 할 개수
  • wait-for-tasks-to-complete-on-shutdown: 애플리케이션 셧다운 시 graceful 지원여부
  • await-termination-seconds: 애플리케이숀 셧다운 시 최대 기다릴 시간(초)

@belljun3395 belljun3395 merged commit 500cd78 into main Jul 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config 설정 파일과 관련된 내용을 다룰 때 사용됩니다 feature 새로운 기능을 만들 때 사용됩니다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

디스코드 훅 비동기 처리 풀 설정
2 participants