[Fix/#346] 단일 워크북 조회시 포함 아티클 정렬이 day 순으로 되어있지 않은 문제 해결 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belljun3395
commented
Aug 15, 2024
| .on(MappingWorkbookArticle.MAPPING_WORKBOOK_ARTICLE.ARTICLE_ID.eq(ArticleMst.ARTICLE_MST.ID)) | ||
| .join(ArticleIfo.ARTICLE_IFO) | ||
| .on(ArticleMst.ARTICLE_MST.ID.eq(ArticleIfo.ARTICLE_IFO.ARTICLE_MST_ID)) | ||
| .where(MappingWorkbookArticle.MAPPING_WORKBOOK_ARTICLE.WORKBOOK_ID.eq(query.workbookId)) | ||
| .and(ArticleMst.ARTICLE_MST.DELETED_AT.isNull) | ||
| .orderBy(MappingWorkbookArticle.MAPPING_WORKBOOK_ARTICLE.DAY_COL) |
There was a problem hiding this comment.
orderBy로 순서 명시해주었습니다.
| .leftJoin(ArticleMst.ARTICLE_MST) | ||
| .join(ArticleMst.ARTICLE_MST) |
There was a problem hiding this comment.
leftjoin이 불필요한 경우라 join으로 변경했습니다. (이번 PR과는 관계없지만..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #346
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트