[Refactor/#358] 아티클 읽음 기록 이벤트 처리로 리펙토링 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belljun3395
commented
Aug 26, 2024
Comment on lines
+13
to
+16
| @EventListener | ||
| fun handleEvent(event: ReadArticleEvent) { | ||
| articleViewHisAsyncHandler.addArticleViewHis(event.articleId, event.memberId, event.category) | ||
| } |
There was a problem hiding this comment.
1차적으로 EventListener에서 이벤트를 받습니다.
|
|
||
| @EventListener | ||
| fun handleEvent(event: ReadArticleEvent) { | ||
| articleViewHisAsyncHandler.addArticleViewHis(event.articleId, event.memberId, event.category) |
There was a problem hiding this comment.
EventListener에서 받은 이벤트를 2차로 처리합니다.
eg)
articleViewHisAsyncHandler.addArticleViewHis는 이벤트를 비동기로 처리함
There was a problem hiding this comment.
이렇게 처리하는게 추후 이벤트를 처리하는 로직이 추가될 때 대응하기 편할 것 같아서 이벤트 처리를 현재 구현과 같이 통일하려 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #358
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
이벤트 리스너까지는 동기로 이후 이벤트 처리는 비동기로 처리하였는데 스레드 및 트렌잭션이 분리되어 있는 것을 확인하였습니다.
🤖 테스트 체크리스트