[Feat/#450] v2 jpa 설정 추가 #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- EnableJpaRepositories - EntityTimeJsonFormat - JpaTransactional
github-actions
bot
added
config
belljun3395
commented
Dec 18, 2024
Comment on lines
+6
to
+8
| @Configuration | ||
| @EnableJpaRepositories(basePackages = [ApiConfig.BASE_PACKAGE]) | ||
| class ApiJpaConfig |
There was a problem hiding this comment.
도메인 모듈을 추가하고 해당 모듈에서 JPA 설정을 해야한다면 위와 같이 설정하면 됩니다.
| @Transactional | ||
| @DataSourceTransactional |
There was a problem hiding this comment.
JPA가 추가되어 TX가 2개가 생겨 명확히 구분이 필요하여 수정하였습니다.
Comment on lines
+10
to
+29
| @MappedSuperclass | ||
| @JsonIgnoreProperties(value = ["createdAt, modifiedAt"], allowGetters = true) | ||
| @EntityListeners(AuditingEntityListener::class) | ||
| abstract class BaseEntity { | ||
| /** 생성일 */ | ||
| @CreatedDate | ||
| @Column(name = "created_at", columnDefinition = "datetime default CURRENT_TIMESTAMP") | ||
| @EntityTimeJsonFormat | ||
| var createdAt: LocalDateTime = LocalDateTime.now() | ||
|
|
||
| /** 수정일 */ | ||
| @LastModifiedDate | ||
| @Column(name = "modified_at", columnDefinition = "datetime default CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP") | ||
| @EntityTimeJsonFormat | ||
| var modifiedAt: LocalDateTime = LocalDateTime.now() | ||
|
|
||
| /** 삭제 여부 */ | ||
| @Column(name = "deleted", columnDefinition = "boolean default false") | ||
| var deleted: Boolean = false | ||
| } |
There was a problem hiding this comment.
BaseEntity 엔티티 입니다.
Comment on lines
13
to
24
| /** | ||
| * org.springframework.data.jpa.repository.config.EnableJpaRepositories를 대체하는 애노테이션 | ||
| * transactionManagerRef와 entityManagerFactoryRef는 JpaConfig에서 설정한 값을 기본으로 사용한다. | ||
| * @see EnableJpaRepositories | ||
| */ | ||
| @Target(AnnotationTarget.CLASS) | ||
| @Retention(AnnotationRetention.RUNTIME) | ||
| @EnableJpaRepositories( | ||
| transactionManagerRef = JpaConfig.JPA_TX, | ||
| entityManagerFactoryRef = JpaConfig.JPA_EMF, | ||
| ) | ||
| annotation class EnableJpaRepositories( |
There was a problem hiding this comment.
EnableJpaRepositories를 대체하는 애노테이션 입니다.
Comment on lines
10
to
17
| /** | ||
| * JPA 트랜잭션을 처리하는 어노테이션 | ||
| * transactionManager는 JpaConfig에서 설정한 값을 기본으로 사용한다. | ||
| */ | ||
| @Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION) | ||
| @Retention(AnnotationRetention.RUNTIME) | ||
| @Transactional(transactionManager = JPA_TX) | ||
| annotation class JpaTransactional( |
There was a problem hiding this comment.
JPA 트랜잭션을 처리하는 어노테이션
belljun3395
commented
Dec 19, 2024
| @Bean(name = [DATASOURCE_TX]) | ||
| fun dataSourceTransactionManager(): PlatformTransactionManager = DataSourceTransactionManager(dataSource) | ||
|
|
||
| override fun annotationDrivenTransactionManager(): TransactionManager = jpaTransactionManager() |
There was a problem hiding this comment.
TransactionManagementConfigurer에서 annotationDrivenTransactionManager()를 오라이드 하면 기본 TX를 설정할 수 있다고 합니다.
저희는 V2에서 JPA를 사용할 예정이라 jpaTransactionManager()를 기본으로 설정하였습니다.
== @Transactional 을 transactionalManager 설정 없이 사용하여도 jpaTransactionManager로 설정된다는 의미
== JooQ 사용할 때 사용하는 dataSourceTransactionalManager는 @DataSourceTransactional를 사용하면 됩니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #450
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🚩 추가된 SQL 운영계 실행계획
🤖 테스트 체크리스트