[Feat/#452] 이벤트 라이브러리 구현 #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
config
belljun3395
commented
Dec 20, 2024
|
|
||
| @Async | ||
| @EventListener | ||
| open fun onApplicationEvent(message: Message) { |
Comment on lines
+27
to
+29
| messageReverseRelays.forEach { relay -> | ||
| relay.javaClass.methods | ||
| .filter { it.name.equals("onApplicationEvent") && it.isForLocalMessageReverseRelay() } |
There was a problem hiding this comment.
LocalMessageReverseRelay 타입의 MessageReverseRelay를 필터링 합니다.
Comment on lines
31
to
36
| val messageType = method.messageType() | ||
| method.getAnnotation(LocalSubscribeMessage::class.java).topic.let { | ||
| if (!method.name.contains(it)) { | ||
| return@forEach | ||
| } | ||
| } |
There was a problem hiding this comment.
LocalSubscribeMessage에서 설정한 토픽과 message로 알 수 있는 topic이 다르면 종료합니다.
Comment on lines
37
to
47
| objectMapper.writeValueAsString(message.payload).let { payload -> | ||
| objectMapper.readValue(payload, MessagePayload::class.java)?.let { messagePayload -> | ||
| objectMapper.convertValue(messagePayload, messageType).let { relayMessage -> | ||
| log.info { | ||
| "[${Thread.currentThread().name}] Publish message to ${relay.javaClass.simpleName}: $relayMessage" | ||
| } | ||
| method.invoke(relay, relayMessage) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
message를 LocalMessageReverseRelay가 받을 수 있는 객체로 바꾼 후 LocalSubscribeMessage의 onApplicationEvent에 전달해 줍니다.
Comment on lines
+25
to
+47
| @Bean | ||
| fun localMessageBeanPostProcessor( | ||
| objectMapper: ObjectMapper, | ||
| messageReverseRelays: List<MessageReverseRelay<*>>, | ||
| ): BeanFactoryPostProcessor = | ||
| BeanFactoryPostProcessor { beanFactory -> | ||
| beanFactory.beanDefinitionNames | ||
| .filter { | ||
| it.contains("Local", ignoreCase = true) && | ||
| it.contains( | ||
| "MessageReverseRelay", | ||
| ignoreCase = true, | ||
| ) | ||
| }.takeIf { it.isNotEmpty() } | ||
| ?.also { localReverseBeanNames -> | ||
| log.info { "LocalReverse Beans are found: ${localReverseBeanNames.joinToString(", ")}" } | ||
| beanFactory.registerSingleton( | ||
| "localMessageBroadCaster", | ||
| LocalMessageBroadCaster(objectMapper, messageReverseRelays), | ||
| ) | ||
| log.info { "Local message broadcaster is registered" } | ||
| } | ||
| } |
There was a problem hiding this comment.
LocalMessageReverseRelay를 구현하였을 때만 localMessageBroadCaster가 등록되도록 합니다.
belljun3395
commented
Dec 21, 2024
Comment on lines
+32
to
+34
| if (!message.javaClass.name.contains(it, ignoreCase = true)) { | ||
| return@forEach | ||
| } |
There was a problem hiding this comment.
LocalSubscribeMessage에서 설정한 토픽과 message로 알 수 있는 topic이 다르면 종료합니다.
기존에 method로 되어 있는것 message로 수정
Comment on lines
+36
to
+39
| objectMapper.convertValue(message.payload, messageType).let { relayMessage -> | ||
| log.info { "[${Thread.currentThread().name}] Publish message to ${relay.javaClass.simpleName}: $relayMessage" } | ||
| method.invoke(relay, relayMessage) | ||
| } |
There was a problem hiding this comment.
message를 LocalMessageReverseRelay가 받을 수 있는 객체로 바꾼 후 LocalSubscribeMessage의 onApplicationEvent에 전달해 줍니다.
기존 불필요하게 수행하였던 message.payload -> json -> messagePayload 객체 과정 제거
hun-ca
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #452
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🚩 추가된 SQL 운영계 실행계획
🤖 테스트 체크리스트