Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GET /api/v1/workbooks/{workbookId}/articles/{articleId} 구현 #65

Merged
merged 30 commits into from
Jun 22, 2024
Merged

feat: GET /api/v1/workbooks/{workbookId}/articles/{articleId} 구현 #65

merged 30 commits into from
Jun 22, 2024

Conversation

belljun3395
Copy link
Collaborator

@belljun3395 belljun3395 commented Jun 21, 2024 •
edited
Loading

🎫 연관 이슈

resolved: #59

💁‍♂️ PR 내용

  • GET /api/v1/workbooks/{workbookId}/articles/{articleId} 구현

🙏 작업

  • ArticleDao#selectWorkBookArticleRecord: 워크북 내에서 아티클의 Day 정보를 포함하여 조회합니다
  • 다른 정보의 경우 기존 구현을 활용하였습니다.

🙈 PR 참고 사항

6dd418f 커밋 이후로 작업을 확인하면 됩니다!

MAPPING_WORKBOOK_ARTICLE 조인 조건을 아래와 같이 PK를 사용하도록 설정하였습니다.
이렇게 해도 괜찮을까요...?
JOIN을 사용할 때 어떤 점을 고려하면 좋을지 궁금합니다.

.from(articleMst)
  .join(articleIfo)
  .on(articleMst.ID.eq(articleIfo.ARTICLE_MST_ID))
  .join(mappingWorkbookArticle)
  .on(mappingWorkbookArticle.WORKBOOK_ID.eq(workbookId))
  .and(mappingWorkbookArticle.ARTICLE_ID.eq(articleMst.ID))
  .where(articleMst.ID.eq(articleId))
  .fetchOneInto(SelectWorkBookArticleRecord::class.java)
  ?: throw IllegalArgumentException("cannot find $workbookId article record by articleId: $articleId")

📸 스크린샷

🤖 테스트 체크리스트

  • 체크 미완료
  • 체크 완료

belljun3395 added 29 commits June 20, 2024 16:26
@belljun3395
refactor: ApiMain 클래스 이동
e05f27f
@belljun3395
feat: api-repo 모듈 ObjectMapper 빈 선언
3583808
@belljun3395
feat: selectArticleRecord 메서드 구현
f0a9f37
@belljun3395
test: selectArticleRecord 테스트 구현
aeafcd1
@belljun3395
feat: selectWriter 메서드 구현
3ae7ab5
@belljun3395
test: selectWriter 테스트 구현
7c5e827
@belljun3395
feat: WriterDescription 구현
dcfcd49
@belljun3395
test: WriterDescriptionMapperTest 테스트 구현
afc82b2
@belljun3395
feat: selectProblemsByArticleId 메서드 구현
68d19fa
@belljun3395
test: selectProblemsByArticleId 테스트 구현
9b59cbd
@belljun3395
feat: Contents 구현
5ac7303
@belljun3395
test: ContentsMapperTest 테스트 구현
bdb5b7e
@belljun3395
feat: BrowseArticleProblemsService 구현
1083483
@belljun3395
feat: ReadWriterRecordService 구현
3a31194
@belljun3395
feat: ReadArticleUseCase 구현
bcacace
@belljun3395
feat: ApiRepoObjectMapperConfig 삭제
186da03
@belljun3395
refactor: init 블록에서 registerKotlinModule 수행되도록 수정
3559444
@belljun3395
refactor: 기본 등록 ObjectMapper 사용하도록 수정
74ce777
@belljun3395
refactor: ReadArticleUseCase 컨트롤러에 적용
8f584ce
@belljun3395
refactor: readArticle 컨트롤러 테스트 유스케이스 목 처리
54c7d6e
@belljun3395
refactor: ReadArticleResponse 응답 구현 수정
e697180
@belljun3395
refactor: 쿼리 객체에 Id 특성을 추가하여 추후 Problems 조회도 가능할 수 있도록 수정
25a2d9d
@belljun3395
refactor: 아티클 작성자를 조회하는 것임을 명확히 하기 위해 수정
8406c74
@belljun3395
chore: 해결된 Todo 삭제
2580136
@belljun3395
feat: selectWorkBookArticleRecord 메서드 구현
6dd418f
@belljun3395
test: selectWorkBookArticleRecord 테스트 구현
a2a8bb7
@belljun3395
feat: ReadWorkBookArticleUseCase 구현
c733ade
@belljun3395
refactor: ReadWorkBookArticleUseCase 컨트롤러에 적용
4efcfb3
@belljun3395
refactor: readWorkBookArticle 컨트롤러에 테스트 유스케이스 목 처리
41cce8b
@belljun3395 belljun3395 requested a review from hun-ca as a code owner June 21, 2024 02:24
@github-actions github-actions bot added the feature 새로운 기능을 만들 때 사용됩니다 label Jun 21, 2024
hun-ca
hun-ca approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@hun-ca hun-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 PR이랑 겹치는 내용도 많고 대체로 틀은 비슷하기 때문에 리뷰할건 없어보이네요!

@belljun3395
Merge branch 'main' into feat/#59_belljun3395
d354d61 
# Conflicts:
#	api-repo/src/main/kotlin/com/few/api/repo/dao/article/ArticleDao.kt
#	api-repo/src/test/kotlin/com/few/api/repo/dao/article/ArticleDaoTest.kt
#	api-repo/src/test/kotlin/com/few/api/repo/dao/member/MemberDaoTest.kt
#	api-repo/src/test/kotlin/com/few/api/repo/dao/problem/ProblemDaoTest.kt
#	api/src/main/kotlin/com/few/api/domain/article/usecase/ReadArticleUseCase.kt
@belljun3395 belljun3395 merged commit be09bd6 into main Jun 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hun-ca hun-ca hun-ca approved these changes

Assignees

@belljun3395 belljun3395

Labels
feature 새로운 기능을 만들 때 사용됩니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /api/v1/workbooks/{workbookId}/articles/{articleId} 구현
2 participants
@belljun3395 @hun-ca