fix: 학습지 구독 취소 URI 변경 #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hun-ca
commented
Jun 22, 2024
Comment on lines
-165
to
+176
| @DisplayName("[DELETE] /api/v1/workbooks/{workbookId}/csubs") | ||
| @DisplayName("[POST] /api/v1/workbooks/{workbookId}/unsubs") | ||
| fun cancelSubWorkBook() { | ||
| // given | ||
| val api = "CancelSubWorkBook" | ||
| val uri = UriComponentsBuilder.newInstance() | ||
| .path("$BASE_URL/{workbookId}/csubs") | ||
| .path("$BASE_URL/{workbookId}/unsubs") | ||
| .build() | ||
| .toUriString() | ||
| // set usecase mock | ||
| val body = objectMapper.writeValueAsString(CancelSubWorkBookBody(email = "[email protected]", opinion = "취소합니다.")) | ||
| val body = objectMapper.writeValueAsString( | ||
| CancelSubWorkBookBody(email = "[email protected]", opinion = "취소합니다.", reason = "이유없음") | ||
| ) |
There was a problem hiding this comment.
body에 reason 추가하고 URL, method 변경
There was a problem hiding this comment.
opinion이랑 reason이랑 동일해 보이는데 추가한 이유가 있나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved #70
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트