refactor: ContentDetailFeature 액션 컨벤션 수정 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealmh
reviewed
Oct 6, 2024
Comment on lines
222
to
214
| return .run { send in | ||
| await send(.delegate(.컨텐츠_조회_완료)) | ||
| await send(.inner(.parsingURL)) | ||
| } | ||
| case .즐겨찾기_갱신(let favorite): | ||
| return .merge( | ||
| .send(.delegate(.컨텐츠_삭제_완료)), | ||
| .send(.inner(.URL_유효성_확인)) | ||
| ) | ||
| case .즐겨찾기_API_반영(let favorite): |
There was a problem hiding this comment.
단순 컨벤션 수정이 아니라 로직자체가 바뀌는형탠데 이에 대한 설명이 없네요..?
There was a problem hiding this comment.
단순 컨벤션 수정이 아니라 로직자체가 바뀌는형탠데 이에 대한 설명이 없네요..?
컨텐츠_조회_완료가 맞는데 제가 실수로 컨텐츠_삭제_완료로 했던거 같아요.. 수정하겠습니다..
Closed
14 tasks
stealmh
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
close 이슈번호