refactor: ContentSettingFeature 액션 컨벤션 수정 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealmh
reviewed
Oct 6, 2024
Comment on lines
190
to
195
| .run { send in | ||
| for await _ in self.pasteboard.changes() { | ||
| let url = try await pasteboard.probableWebURL() | ||
| await send(.inner(.linkPopup(url)), animation: .pokitSpring) | ||
| } | ||
| } |
stealmh
reviewed
Oct 6, 2024
Comment on lines
202
to
208
| let isEdit = state.domain.categoryId != nil | ||
|
|
||
| if isEdit { | ||
| return .send(.async(.컨텐츠_수정_API)) | ||
| } else { | ||
| return .send(.async(.컨텐츠_추가_API)) | ||
| } |
There was a problem hiding this comment.
isEdit
? return .action
: return .action
stealmh
requested changes
Oct 6, 2024
Closed
14 tasks
넵..!! 너무 생각없이 적었습니다. 주의하겠습니다..!! 함수로 빼는 방향으로 가겠습니다 |
stealmh
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
close 이슈번호