refactor: 로그인 플로우 Feature 액션 컨벤션 수정 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealmh
reviewed
Oct 6, 2024
| case .다음_버튼_눌렀을때: | ||
| let nickname = state.nicknameText | ||
| return .send(.delegate(.pushSelectFieldView(nickname: nickname))) | ||
| case .뒤로가기_버튼_눌렀을때: |
There was a problem hiding this comment.
요거 네이밍도
dismiss로 그냥 가져갑니다
넵
stealmh
reviewed
Oct 6, 2024
Comment on lines
106
to
108
| return .send( | ||
| .inner(.닉네임_변경되었을때) | ||
| ) |
There was a problem hiding this comment.
한줄로 적을 수 있는데 이런 컨벤션을 저희가 정했었나요??
There was a problem hiding this comment.
한줄로 적을 수 있는데 이런 컨벤션을 저희가 정했었나요??
엇 제가 잘못적은거 같아요 수정하겠습니다
stealmh
reviewed
Oct 6, 2024
Comment on lines
120
to
121
| case .textChanged: | ||
| case .닉네임_변경되었을때: |
There was a problem hiding this comment.
액션 이름 자체는 유저가 닉네임을 변경한 이후(닉네임 API 반영)로 보여집니다
닉네임 텍스트필드가 변경되었다는 네이밍을 다시한번 생각해보면 좋을 것 같습니다
There was a problem hiding this comment.
액션 이름 자체는 유저가 닉네임을 변경한 이후(닉네임 API 반영)로 보여집니다 닉네임 텍스트필드가 변경되었다는 네이밍을 다시한번 생각해보면 좋을 것 같습니다
넵 수정하겠습니다
stealmh
reviewed
Oct 6, 2024
Comment on lines
50
to
53
| case 개인정보_동의_선택됐을때 | ||
| case 서비스_이용약관_동의_선택됐을때 | ||
| case 마케팅_정보_수신_동의_선택됐을때 | ||
| case 전체_동의_선택됐을때 |
Closed
14 tasks
stealmh
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
close 이슈번호