refactor: PokitFeature 액션 수정 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
14 tasks
ShapeKim98
approved these changes
Oct 18, 2024
| @@ -256,40 +252,40 @@ private extension PokitRootFeature { | |||
| /// - Inner Effect | |||
| func handleInnerAction(_ action: Action.InnerAction, state: inout State) -> Effect<Action> { | |||
| switch action { | |||
| case let .pokitCategorySheetPresented(presented): | |||
| case let .카테고리_시트_활성화(presented): | |||
There was a problem hiding this comment.
앞으로 뷰 띄우는 액션은 활성화라고 하면 될까여?
There was a problem hiding this comment.
넵 ~~_활성화(true), _활성화(false)가 더 눈에 잘 들어오는것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#129
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)