Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: UI 피드백 반영 #159

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix: UI 피드백 반영 #159

merged 2 commits into from
Nov 19, 2024

Conversation

ShapeKim98
Copy link
Contributor

@ShapeKim98 ShapeKim98 commented Nov 19, 2024

#️⃣연관된 이슈

#158

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • PokitAlertBoxView의 알림 목록 empty의 UX 워딩을 수정하였습니다.
  • PokitLinkPreview에서 기본 이미지가 영역을 벗어나는 현상을 수정하였습니다.

스크린샷 (선택)

Simulator Screenshot - iPhone 16 Pro - 2024-11-19 at 16 29 57 Simulator Screenshot - iPhone 16 Pro - 2024-11-19 at 16 30 37

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

  • 이거 머지하고 바로 1.0.4 릴리즈 할 예정입니다

image

  • UI 점검하다가 발견했는데.. 포킷 목록이 살짝 위쪽으로 짤린거 같은데 원인을 모르겠어요...

close #158

@ShapeKim98 ShapeKim98 added the Design 🎨 디자인 작업 label Nov 19, 2024
@ShapeKim98 ShapeKim98 requested a review from stealmh November 19, 2024 07:40
@ShapeKim98 ShapeKim98 self-assigned this Nov 19, 2024
@stealmh stealmh linked an issue Nov 19, 2024 that may be closed by this pull request
@ShapeKim98 ShapeKim98 merged commit a6ca168 into develop Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design 🎨 디자인 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI 수정
2 participants