feat: 1.0.6베타 QA 반영 #168
Merged
feat: 1.0.6베타 QA 반영 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealmh
reviewed
Dec 10, 2024
Comment on lines
+226
to
+233
| case let .카테고리상세_이동(category): | ||
| if category.categoryName == "미분류" { | ||
| state.selectedTab = .pokit | ||
| state.path.removeAll() | ||
| return .send(.pokit(.delegate(.미분류_카테고리_활성화))) | ||
| } | ||
| state.path.append(.카테고리상세(.init(category: category))) | ||
| return .none |
There was a problem hiding this comment.
유저마다 미분류 id값이 다르다면 저희가 할 수 있는 최선은 Constants로 빼내는것이긴 한데 ...
단순 문자열로 비교는 좀 별로긴하네요 서버쪽에서 해결해줘야 할 것 같아요..😂
stealmh
reviewed
Dec 10, 2024
| listSheet | ||
| .presentationDragIndicator(.visible) | ||
| .pokitPresentationCornerRadius() | ||
| .presentationDetents([.height(564)]) |
There was a problem hiding this comment.
엇.. 확인 해보겠습니다.. 확인한다 해놓고 까먹고 있었,,
stealmh
reviewed
Dec 10, 2024
Comment on lines
+376
to
+382
| guard | ||
| let contentId = state.domain.contentId, | ||
| let categoryId = state.selectedPokit?.id, | ||
| let category = state.domain.categoryListInQuiry.data?.first(where: { | ||
| $0.id == categoryId | ||
| }) | ||
| else { return .none } |
There was a problem hiding this comment.
이런 컨벤션 좋긴한데 적용하실거면 통일성을 위해서 모든 guard let에 적용하는게 맞다고 생각함
아니라면 이전 컨벤션 적용하고 나중에 전체수정하는걸루
There was a problem hiding this comment.
그럼 괜찮으시다면 다 적용해도 될까요..?
stealmh
approved these changes
Dec 10, 2024
|
고생많으셨습니다~~! 2버전을 향해서 으쌰 |
11 tasks
stealmh
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#167
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
categoryName을 비교하여 분기하고 있습니다.(단순 이름 비교라 좀 맘에 안들기도 함...)사용자 별로 미분류 포킷 id가 다르기 때문에 이렇게 하였고, 저번 pr 처럼
"미분류"라는 문자열을Constant로 넣으면 좋을지..? 궁금합니다close #167