-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : 헤더 값 요청 수정 #161
Merged
Merged
fix : 헤더 값 요청 수정 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaBaljaintheroom
changed the base branch from
fix/structrues
to
temp-develop
September 12, 2024 08:36
GaBaljaintheroom
changed the base branch from
temp-develop
to
fix/structrues
September 12, 2024 08:36
@GaBaljaintheroom 준수님 혹시 커밋이 좀 꼬인 걸까요? 아니면 지금 리뷰 안 해도 되는 PR인 걸까요? |
아 이건 temp-develop에서 분기 한 것 이 아니라 fix/structure에서 분기한거라 리뷰는 해주셔도 되요. |
Closed
devmizz
suggested changes
Sep 14, 2024
app/api/user-api/src/main/java/org/example/controller/UserController.java
Outdated
Show resolved
Hide resolved
app/infrastructure/redis/src/main/java/org/example/repository/RedisTokenRepository.java
Outdated
Show resolved
Hide resolved
app/domain/user-domain/src/main/java/org/example/usecase/user/UserUseCase.java
Outdated
Show resolved
Hide resolved
devmizz
reviewed
Sep 14, 2024
app/api/common-api/src/main/java/org/example/filter/JWTFilter.java
Outdated
Show resolved
Hide resolved
devmizz
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 승인 해놓을게요!
app/api/show-api/src/main/java/com/example/artist/controller/ArtistController.java
Outdated
Show resolved
Hide resolved
app/api/show-api/src/test/java/artist/service/ArtistServiceTest.java
Outdated
Show resolved
Hide resolved
수정완료! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😋 작업한 내용
🙏 PR Point
👍 관련 이슈