-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cursor 데이터 일치 #163
Closed
Closed
fix: cursor 데이터 일치 #163
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0dffe24
fix: UserShowController 이동
GaBaljaintheroom 53ccee2
fix: 알림 설정한 공연 개수 쿼리 위치 이동
GaBaljaintheroom 241a63a
fix: CI 추가
GaBaljaintheroom 2e1009c
fix: cursor 데이터 일치
GaBaljaintheroom 958c904
fix: 기본 커서 페이지 사이즈와 응답 메서드명 수정
GaBaljaintheroom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ on: | |
pull_request: | ||
branches: | ||
- develop | ||
- temp-develop | ||
|
||
jobs: | ||
build: | ||
|
22 changes: 22 additions & 0 deletions
22
app/api/common-api/src/main/java/org/example/dto/response/CursorApiResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package org.example.dto.response; | ||
|
||
import io.swagger.v3.oas.annotations.media.Schema; | ||
import java.util.UUID; | ||
|
||
public record CursorApiResponse( | ||
|
||
@Schema(description = "조회한 데이터의 Cursor Id") | ||
UUID id, | ||
|
||
@Schema(description = "조회한 데이터의 Cursor Value") | ||
Object value | ||
) { | ||
public static CursorApiResponse toCursorResponse(UUID id, Object value) { | ||
return new CursorApiResponse(id, value); | ||
} | ||
|
||
public static CursorApiResponse toCursorId(UUID id) { | ||
return new CursorApiResponse(id, ""); | ||
} | ||
|
||
} |
14 changes: 14 additions & 0 deletions
14
app/api/common-api/src/main/java/org/example/util/ValidatorCursorSize.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package org.example.util; | ||
|
||
public final class ValidatorCursorSize { | ||
|
||
private static final Integer DEFAULT_SIZE = 30; | ||
|
||
public static int getDefaultSize(Integer size) { | ||
if (size == null) { | ||
return DEFAULT_SIZE; | ||
} | ||
|
||
return size; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
.../java/com/example/artist/controller/dto/response/NumberOfSubscribedArtistApiResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package com.example.artist.controller.dto.response; | ||
|
||
|
||
import com.example.artist.service.dto.response.NumberOfSubscribedArtistServiceResponse; | ||
|
||
public record NumberOfSubscribedArtistApiResponse( | ||
long count | ||
) { | ||
|
||
public static NumberOfSubscribedArtistApiResponse from( | ||
NumberOfSubscribedArtistServiceResponse response | ||
) { | ||
return new NumberOfSubscribedArtistApiResponse(response.count()); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 포인트: 5
default 30, min은 없고, maz 30이에요!
입력이 들어오지 않았을 때 30으로 기본 할당 되어야 해요!