Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Setting checkstyle #17

Merged
merged 3 commits into from
Jun 3, 2024
Merged

feat: Setting checkstyle #17

merged 3 commits into from
Jun 3, 2024

Conversation

devmizz
Copy link
Contributor

@devmizz devmizz commented Jun 2, 2024

πŸ˜‹ μž‘μ—…ν•œ λ‚΄μš©

  • checkstyle 등둝
  • pre-commit 등둝

πŸ™ PR Point

  • pre-commit은 compile μ‹œμ— μžλ™μœΌλ‘œ 등둝이 λ©λ‹ˆλ‹€.
  • μ½”λ“œ μž‘μ„± 쀑, lintλ₯Ό μˆ˜μ •ν•˜κ³  싢은 게 μžˆλ‹€λ©΄ root/config/checkstyle.xml μ—μ„œ μˆ˜μ •ν•˜λ©΄ λ©λ‹ˆλ‹€.
  • checkstyle plugin μ„€μΉ˜ν•˜λ©΄ 린트 μ—λŸ¬ 쑰금 더 νŽΈν•˜κ²Œ μ‚΄νŽ΄λ³Ό 수 μžˆμŠ΅λ‹ˆλ‹€.

πŸ‘ κ΄€λ ¨ 이슈

@devmizz devmizz added the feat add feature label Jun 2, 2024
@devmizz devmizz requested a review from GaBaljaintheroom June 2, 2024 12:17
@devmizz devmizz self-assigned this Jun 2, 2024
GaBaljaintheroom
GaBaljaintheroom approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@GaBaljaintheroom GaBaljaintheroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€. 덕뢄에 ν•˜λ‚˜ 더 μ•Œμ•„κ°‘λ‹ˆλ‹€!! κ°μ‚¬ν•©λ‹ˆλ‹€! 미리 승인 ν•΄λ†“κ² μŠ΅λ‹ˆλ‹€.

@devmizz devmizz merged commit 114c759 into develop Jun 3, 2024
1 check passed
@devmizz devmizz deleted the feat-lint branch June 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaBaljaintheroom GaBaljaintheroom GaBaljaintheroom approved these changes

Assignees

@devmizz devmizz

Labels
feat add feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmizz @GaBaljaintheroom