feat : 엔티티 세팅 #22
Merged
feat : 엔티티 세팅 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmizz
suggested changes
Jun 16, 2024
There was a problem hiding this comment.
멀티 모듈을 사용하면서 도메인 단위로 모듈을 찢을 때, 도메인의 적절한 크기도 중요해요. 같은 계층에서 도메인 간의 의존이 좋지는 않으니깐요. 서비스가 서비스를 참조하면 내포하고 있는 위험성이 많은 것처럼요. 지금은 도메인을 적절하게 분리하지 않고 테이블 단위로 다 찢어놓은 느낌이에요.
지금의 분리는 편의성도 도메인도 모두 포기한 체, 기계적으로 테이블 단위로 모두 찢은 거 같아요. 조금만 더 고민해보면 좋을 거 같아요! 혹시 다른 의견이 있으면 편하게 주십쇼!
app/domain/artist-domain/src/main/java/org/example/entity/Artist.java
Outdated
Show resolved
Hide resolved
app/domain/artist-domain/src/main/java/org/example/entity/ArtistSearch.java
Outdated
Show resolved
Hide resolved
app/domain/genre-domain/src/main/java/org/example/entity/Genre.java
Outdated
Show resolved
Hide resolved
app/domain/genre-domain/src/main/java/org/example/entity/Genre.java
Outdated
Show resolved
Hide resolved
app/domain/show-domain/src/main/java/org/example/entity/ShowSearch.java
Outdated
Show resolved
Hide resolved
app/domain/show-domain/src/main/java/org/example/entity/info/Price.java
Outdated
Show resolved
Hide resolved
app/domain/show-domain/src/main/java/org/example/vo/TicketBookingSite.java
Outdated
Show resolved
Hide resolved
app/domain/ticket-alert-domain/src/main/java/org/example/entity/TicketingAlert.java
Outdated
Show resolved
Hide resolved
devmizz
suggested changes
Jun 18, 2024
app/domain/show-domain/src/main/java/org/example/vo/TicketBookingSite.java
Outdated
Show resolved
Hide resolved
app/domain/genre-domain/src/main/java/org/example/entity/Genre.java
Outdated
Show resolved
Hide resolved
app/domain/show-domain/src/main/java/org/example/entity/show/ShowImage.java
Outdated
Show resolved
Hide resolved
app/domain/show-domain/src/main/java/org/example/entity/show/ShowGenre.java
Outdated
Show resolved
Hide resolved
app/domain/show-domain/src/main/java/org/example/entity/show/Show.java
Outdated
Show resolved
Hide resolved
app/domain/show-domain/src/main/java/org/example/entity/artist/Artist.java
Outdated
Show resolved
Hide resolved
app/domain/show-domain/src/main/java/org/example/entity/genre/Genre.java
Outdated
Show resolved
Hide resolved
app/domain/user-domain/src/main/java/org/example/entity/TicketingAlert.java
Outdated
Show resolved
Hide resolved
|
Ticketing에 대해 생각해보았는데, 테이블로 분리까지는 굳이라는 생각이 들었어요. 그래서 일단 Map의 키를 enum -> String으로 유연하게 변경해보았습니다. |
devmizz
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😋 작업한 내용
🙏 PR Point
👍 관련 이슈