Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 어드민 가입 기능 구현 #29

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Conversation

GaBaljaintheroom
Copy link
Contributor

😋 작업한 내용

  • Spring Security를 이용한 어드민 로그인 , 로그아웃 기능 구현

🙏 PR Point

  • Spring Security에서 어드민 인증, 인가를 구현하였는데, 어드민일 경우 User엔티티에 password 필드가 있으면 좋을 것 같다고 생각했습니다. 그러나 showPot User은 password는 필요가 없기도하고... password를 그냥 application.yml에 넣어두긴했습니다..ㅎ

👍 관련 이슈


@GaBaljaintheroom GaBaljaintheroom self-assigned this Jul 8, 2024
@GaBaljaintheroom GaBaljaintheroom added the feat add feature label Jul 8, 2024
Copy link
Contributor

@devmizz devmizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고민하신 부분에 대해서, 어드민용 테이블을 따로 만들어도 괜찮지 않을까 싶기도 하네요!

@GaBaljaintheroom
Copy link
Contributor Author

회의 후 결정한 어드민 인증/인가는 삭제하고 이후 어드민 회원가입을 구현하였습니다. SecurityConfig도 가독성있게 수정해보았습니다.

@GaBaljaintheroom GaBaljaintheroom changed the title feat : 어드민 인증 기능 구현 feat : 어드민 가입 기능 구현 Jul 11, 2024
@GaBaljaintheroom GaBaljaintheroom merged commit 6f0af43 into develop Jul 16, 2024
1 check passed
@GaBaljaintheroom GaBaljaintheroom deleted the feat/admin_login branch July 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat add feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants