refactor: add hasOwnerMemberId in photo entity

YAPP-Github · Jul 28, 2024 · 9f6833b · 9f6833b
1 parent b54b3f4
commit 9f6833b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/photo-service/src/main/java/kr/mafoo/photo/domain/PhotoEntity.java b/photo-service/src/main/java/kr/mafoo/photo/domain/PhotoEntity.java
@@ -62,6 +62,10 @@ public String getId() {
         return photoId;
     }
 
+    public Boolean hasOwnerMemberId() {
+        return this.getOwnerMemberId() != null;
+    }
+
     public PhotoEntity updateOwnerMemberId(String ownerMemberId) {
         this.ownerMemberId = ownerMemberId;
         return this;

diff --git a/photo-service/src/main/java/kr/mafoo/photo/service/PhotoService.java b/photo-service/src/main/java/kr/mafoo/photo/service/PhotoService.java
@@ -69,7 +69,7 @@ public Mono<PhotoEntity> updatePhotoAlbumId(String photoId, String albumId, Stri
                 .switchIfEmpty(Mono.error(new PhotoNotFoundException()))
                 .flatMap(photoEntity -> {
 
-                    if (!hasOwnerId(photoEntity)) {
+                    if (!photoEntity.hasOwnerMemberId()) {
                         photoRepository.save(photoEntity.updateOwnerMemberId(requestMemberId));
                     }
 
@@ -94,8 +94,4 @@ public Mono<PhotoEntity> updatePhotoAlbumId(String photoId, String albumId, Stri
                 });
     }
 
-    private Boolean hasOwnerId(PhotoEntity photoEntity) {
-        return photoEntity.getOwnerMemberId() != null;
-    }
-
 }