Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] add comment formatting function by VS Code language ID #25

Merged
merged 10 commits into from
May 2, 2024
Merged

[Feat] add comment formatting function by VS Code language ID #25

merged 10 commits into from
May 2, 2024

Conversation

glassk
Copy link
Member

@glassk glassk commented Apr 30, 2024 •
edited
Loading

Closes #14

Description

2024-04-30.5.11.45.mov

ETC

Checklist (Merge should only be performed once all of the following conditions are checked.)

  • I have completed the necessary tests and verified that the functionality works as intended.
  • I have written the code according to the code style guide.
  • I have confirmed that only the intended files and changes have been committed.
  • I have discussed these changes with my team members in advance, and all team members are aware of this PR.

@glassk glassk self-assigned this Apr 30, 2024
@glassk glassk requested review from givvemee and fliklab as code owners April 30, 2024 08:05
@glassk glassk added the enhancement New feature or request label Apr 30, 2024
glassk
glassk commented Apr 30, 2024
View reviewed changes
jest.config.cjs Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
glassk
glassk commented Apr 30, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
givvemee
givvemee reviewed Apr 30, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/tests/extension.test.ts Outdated Show resolved Hide resolved
src/tests/utils/generateFileNameComment.test.ts Outdated Show resolved Hide resolved
src/utils/generateFileNameComment.ts Show resolved Hide resolved
@givvemee
Copy link
Member

우리 새로운 기능 추가하는 거 src 밑에 util 파일 만들자고 얘기해야지 생각만 하고 전 이미 그렇게 작업하고 있었는데 역시 유리 님도 알잘딱 해 주셨군요. 👍

@glassk glassk force-pushed the feat/format-comment-by-lang branch from 00e512f to e39dc72 Compare May 2, 2024 12:44
@glassk glassk requested a review from fliklab May 2, 2024 13:35
@glassk glassk requested a review from givvemee May 2, 2024 14:05
@glassk glassk merged commit df5ffc4 into dev May 2, 2024
2 checks passed
@glassk glassk deleted the feat/format-comment-by-lang branch May 2, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@givvemee givvemee givvemee approved these changes

@fliklab fliklab fliklab approved these changes

Assignees

@glassk glassk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: add comment format by VS Code language ID
3 participants
@glassk @givvemee @fliklab