Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add CI and release workflow configuration #39

Merged
merged 4 commits into from
May 11, 2024

Conversation

glassk
Copy link
Member

@glassk glassk commented May 9, 2024

Closes #34

Description

  • Add CI and release Workflow Configuration(Merges from dev to main)
    • test(vscode, mocha)
    • push git tag
    • update release note or change log

ETC

Checklist (Merge should only be performed once all of the following conditions are checked.)

  • I have completed the necessary tests and verified that the functionality works as intended.
  • I have written the code according to the code style guide.
  • I have confirmed that only the intended files and changes have been committed.
  • I have discussed these changes with my team members in advance, and all team members are aware of this PR.

@glassk glassk self-assigned this May 9, 2024
@glassk glassk linked an issue May 9, 2024 that may be closed by this pull request
3 tasks
@glassk glassk changed the title [chore] /ci from dev to main [chore] add CI and release workflow configuration May 9, 2024
@fliklab
Copy link
Contributor

fliklab commented May 9, 2024

package.json의 버전이 안올라갔거나, changelog.md가 업데이트 안된 경우 머지가 안되도록 하는 식의 장치도 있으면 좋을 것 같습니다!

@givvemee givvemee added the enhancement New feature or request label May 10, 2024
@glassk glassk marked this pull request as ready for review May 11, 2024 06:42
@glassk glassk requested review from givvemee and fliklab as code owners May 11, 2024 06:42
@glassk
Copy link
Member Author

glassk commented May 11, 2024

package.json의 버전이 안올라갔거나, changelog.md가 업데이트 안된 경우 머지가 안되도록 하는 식의 장치도 있으면 좋을 것 같습니다!

#39 (comment)

.github/workflows/pr-check-version_upgrade.yml로 추가해보았습니다!

@givvemee
Copy link
Member

이거 테스트는 할 수 없는 건가여?

@glassk glassk merged commit 8ac13ab into dev May 11, 2024
2 checks passed
@glassk glassk deleted the chore/ci-from-dev-to-main branch May 11, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: add CI and release workflow configuration
3 participants