Add hud_watermark command #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Oct 28, 2024
YaLTeR
reviewed
Oct 30, 2024
cl_dll/hud_watermark.cpp
Outdated
| gEngfuncs.pfnDrawString(ScreenWidth / 20, gHUD.m_scrinfo.iCharHeight, "OpenAG client build " __DATE__, r, g, b); | ||
| gEngfuncs.pfnDrawString(ScreenWidth / 20, gHUD.m_scrinfo.iCharHeight * 2, "j.mp/OpenAG", r, g, b); | ||
|
|
||
| if (update_is_available) |
There was a problem hiding this comment.
Maybe if an update is available, then this part of the HUD should be shown regardless of hud_watermark? What do you think?
There was a problem hiding this comment.
Maybe if an update is available, then this part of the HUD should be shown regardless of hud_watermark? What do you think?
Perhaps the update disclaimer can be shown for a shorter time if hud_watermark == 0.
There was a problem hiding this comment.
Changes have been pushed
YaLTeR
reviewed
Nov 6, 2024
YaLTeR
reviewed
Nov 11, 2024
|
Please apply all suggestions, then it's good. |
|
No worries I'll do it when I'm home from work and squash the commits so it's tidier
|
hud_watermark <0|1> (1 by default) Controls whether the watermark & server-settings will display or not. The update disclaimer will display regardless, but only for 5 seconds if hud_watermark is set to 0. Co-Authored-By: Ivan Molodetskikh <[email protected]>
sabianroberts
force-pushed
the
openag-hud_watermark
branch
from
bb825e4 to
793f88a
Compare
|
@YaLTeR changes have been pushed and squashed into 1 tidy commit. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command to toggle the HUD watermark that displays upon connecting to a server. Default value is 1.