Fall back to primary gpu for rendering #1281
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
from
dd7e90d to
5e37e19
Compare
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
from
5e37e19 to
f2be61c
Compare
|
doc builds fail caused by ongoing migration of fdo gitlab |
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
2 times, most recently
from
1f85ad6 to
6083bb4
Compare
YaLTeR
reviewed
Mar 16, 2025
Comment on lines
+533
to
+560
| .or(self | ||
| .devices | ||
| .get(&self.primary_node) | ||
| .map(|device| &device.gbm)) |
There was a problem hiding this comment.
What happens if udev adds this device before the primary node device?
There was a problem hiding this comment.
Nothing bad, but the display link device would not work. I tried to address this in a new commit by "pre-initializing" the primary node.
| debug!("this is the primary render node"); | ||
| } | ||
|
|
||
| let mut renderer = self | ||
| .gpu_manager | ||
| .single_renderer(&render_node) | ||
| .single_renderer(&self.primary_render_node) |
There was a problem hiding this comment.
I think it would be useful to extract this change to use self.primary_render_node into its own commit just in case future bisecting needs it
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
from
6083bb4 to
8cf0d09
Compare
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
2 times, most recently
from
87db764 to
c4a170b
Compare
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
from
c4a170b to
6571e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on Smithay/smithay#1680
fixes #910