Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getImage returning now the FilePath #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Istani
Copy link

@Istani Istani commented Jul 17, 2021

sorry but it was bothering me for ages, that it always returns undefined...
and now i starts getting into node_modules and pull requests ;)

so please dont judge me to hard^^

@Istani
Copy link
Author

Istani commented Jul 17, 2021

Sorry, i just didnt think about the group part... but does it works? it didnt recive img or msg for me...
And how about, using the sended file extension? - its a cheap solution but you could receive videos^^

and add 2 ToDos^^

@Istani Istani marked this pull request as draft July 17, 2021 13:19
@Istani
Copy link
Author

Istani commented Jul 18, 2021

i am done...

@Istani Istani marked this pull request as ready for review July 18, 2021 12:04
Copy link

@bluemods bluemods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file-content-tpe should be file-content-type on line 78

Also WARNING:

Uri tags can be spoofed, meaning that a user can pass a malicious url in as input and the client will automatically attempt to load the url.

This introduces several huge vulnerabilities to the API, I recommend that it not be accepted in its current form. Either whitelist URLs for automatic download such as *.kik.com, *.tenor.com, etc, or allow the user to pick what type of content will automatically be downloaded. app-name can also be maliciously changed, use the app-id attribute instead for figuring out what content type it is.

@Istani
Copy link
Author

Istani commented Jul 27, 2021

@bluemods Thank you for pointing that out.
I hope @YassienW somedays comes back to this module...

I, myself, plan on changing a lot of things... but time is flying by...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants