-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getImage returning now the FilePath #32
base: master
Are you sure you want to change the base?
Conversation
Sorry, i just didnt think about the group part... but does it works? it didnt recive img or msg for me... and add 2 ToDos^^ |
i am done... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file-content-tpe
should be file-content-type
on line 78
Also WARNING:
Uri
tags can be spoofed, meaning that a user can pass a malicious url in as input and the client will automatically attempt to load the url.
This introduces several huge vulnerabilities to the API, I recommend that it not be accepted in its current form. Either whitelist URLs for automatic download such as *.kik.com, *.tenor.com, etc, or allow the user to pick what type of content will automatically be downloaded. app-name
can also be maliciously changed, use the app-id
attribute instead for figuring out what content type it is.
sorry but it was bothering me for ages, that it always returns undefined...
and now i starts getting into node_modules and pull requests ;)
so please dont judge me to hard^^