Support for .NET Core 3.1 #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plain Elastic is migrated to .NET Standard Tests are now in .NET Core There are missing extension methods from latest dependencies. Wrote them on my own. This is primarily for testing and not for the core library. This is how the Core project is created * Open the solution in VS for Mac * Create a new .NET Standard project under the solution * use `git mv` command to move the files from .NET Fx project to .NET standard project. * Similarly do the same for other projects. * Test project is based on NUnit framework primarily. * Update the Newtonsoft.JSON and other dependencies to latest
…empt created a .NET Core application instead of a test project, so the tests were not detected by the IDE at all
…ct to facilitate running tests from IDE. Now it works from within Visual Studio for Mac
…called on a null object the test fails. The fix is to check for nulls before invoking methods on an object. If both object and it's comparison are null return true, if object is null and comparison is not return false. If both are not null do the actual equals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.