Raise these so that we get the full picture on failure and can decide…

… what to do in dynamodb_state_store
Yelp · Oct 25, 2024 · e4caf72 · e4caf72
1 parent df6614b
commit e4caf72
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/tron/actioncommand.py b/tron/actioncommand.py
@@ -214,10 +214,10 @@ def to_json(state_data: dict) -> Optional[str]:
             )
         except KeyError:
             log.exception("Missing key in state_data:")
-            return None
+            raise
         except Exception:
             log.exception("Error serializing SubprocessActionRunnerFactory to JSON:")
-            return None
+            raise
 
 
 def create_action_runner_factory_from_config(config):

diff --git a/tron/core/action.py b/tron/core/action.py
@@ -91,10 +91,10 @@ def serialize_namedtuple(obj):
             )
         except KeyError:
             log.exception("Missing key in state_data:")
-            return None
+            raise
         except Exception:
             log.exception("Error serializing ActionCommandConfig to JSON:")
-            return None
+            raise
 
 
 @dataclass

diff --git a/tron/core/actionrun.py b/tron/core/actionrun.py
@@ -191,10 +191,10 @@ def to_json(state_data: dict) -> Optional[str]:
             )
         except KeyError:
             log.exception("Missing key in state_data:")
-            return None
+            raise
         except Exception:
             log.exception("Error serializing ActionRunAttempt to JSON:")
-            return None
+            raise
 
     @classmethod
     def from_state(cls, state_data):
@@ -770,10 +770,10 @@ def to_json(state_data: dict) -> Optional[str]:
             )
         except KeyError:
             log.exception("Missing key in state_data:")
-            return None
+            raise
         except Exception:
             log.exception("Error serializing ActionRun to JSON:")
-            return None
+            raise
 
     def render_template(self, template):
         """Render our configured command using the command context."""

diff --git a/tron/core/job.py b/tron/core/job.py
@@ -129,7 +129,7 @@ def to_json(state_data: dict) -> Optional[str]:
             return json.dumps(state_data)
         except Exception:
             log.exception("Error serializing Job to JSON:")
-            return None
+            raise
 
     @classmethod
     def from_config(

diff --git a/tron/core/jobrun.py b/tron/core/jobrun.py
@@ -97,10 +97,10 @@ def to_json(state_data: dict) -> Optional[str]:
             )
         except KeyError:
             log.exception("Missing key in state_data:")
-            return None
+            raise
         except Exception:
             log.exception("Error serializing JobRun to JSON:")
-            return None
+            raise
 
     @property
     def id(self):