Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Commit

Permalink
Revert "CLUSTERMAN-812: upgrade k8s client library (#334)"
Browse files Browse the repository at this point in the history
This reverts commit 6c4b8bb.
  • Loading branch information
nemacysts committed Oct 18, 2023
1 parent 499a26e commit 8b8ad6e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
4 changes: 2 additions & 2 deletions clusterman/kubernetes/kubernetes_cluster_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
import colorlog
import kubernetes
import staticconf
from kubernetes.client import V1beta1Eviction
from kubernetes.client import V1DeleteOptions
from kubernetes.client import V1Eviction
from kubernetes.client import V1ObjectMeta
from kubernetes.client.models.v1_node import V1Node as KubernetesNode
from kubernetes.client.models.v1_pod import V1Pod as KubernetesPod
Expand Down Expand Up @@ -356,7 +356,7 @@ def _evict_pod(self, pod: KubernetesPod):
self._core_api.create_namespaced_pod_eviction(
name=pod.metadata.name,
namespace=pod.metadata.namespace,
body=V1Eviction(
body=V1beta1Eviction(
metadata=V1ObjectMeta(
name=pod.metadata.name,
namespace=pod.metadata.namespace,
Expand Down
3 changes: 1 addition & 2 deletions clusterman/kubernetes/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
from kubernetes.client.models.v1_node_selector_requirement import V1NodeSelectorRequirement
from kubernetes.client.models.v1_node_selector_term import V1NodeSelectorTerm
from kubernetes.client.models.v1_pod import V1Pod as KubernetesPod
from kubernetes.config.config_exception import ConfigException

from clusterman.util import ClustermanResources

Expand Down Expand Up @@ -73,7 +72,7 @@ def __init__(self, kubeconfig_path: str, client_class: Type) -> None:
kubernetes.config.load_incluster_config()
else:
kubernetes.config.load_kube_config(kubeconfig_path, context=os.getenv("KUBECONTEXT"))
except (TypeError, ConfigException):
except TypeError:
error_msg = "Could not load KUBECONFIG; is this running on Kubernetes master?"
if "yelpcorp" in socket.getfqdn():
error_msg += "\nHint: try using the clusterman-k8s-<clustername> wrapper script!"
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ idna==2.8
jmespath==0.9.4
jsonpickle==1.4.2
kiwisolver==1.1.0
kubernetes==24.2.0
kubernetes==10.0.1
matplotlib==3.4.2
mypy-extensions==0.4.3
numpy==1.21.6
Expand Down
3 changes: 1 addition & 2 deletions tests/kubernetes/util_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import pytest
from kubernetes.client.models.v1_node_selector_requirement import V1NodeSelectorRequirement
from kubernetes.client.models.v1_node_selector_term import V1NodeSelectorTerm
from kubernetes.config import ConfigException

from clusterman.kubernetes.util import CachedCoreV1Api
from clusterman.kubernetes.util import ConciseCRDApi
Expand All @@ -22,7 +21,7 @@ def mock_cached_core_v1_api():


def test_cached_corev1_api_no_kubeconfig(caplog):
with pytest.raises(ConfigException):
with pytest.raises(TypeError):
CachedCoreV1Api("/foo/bar/admin.conf")
assert "Could not load KUBECONFIG" in caplog.text

Expand Down

0 comments on commit 8b8ad6e

Please sign in to comment.