Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Fix build failing because of dependencies conflict #279

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Fix build failing because of dependencies conflict #279

merged 3 commits into from
Nov 4, 2021

Conversation

amribr
Copy link
Contributor

@amribr amribr commented Nov 3, 2021

Changes:

  • Updated ipdb and ipython as they failed to install because of incompatibility issues with setuptools==58.3.0
  • Pinned PyYAML in requirements-dev.txt as PyYAML==6.0 is not compatible with pre-commit==0.8.0 and docker-compose==1.7.0

@amribr amribr requested a review from JayH5 November 3, 2021 12:42
JayH5
JayH5 reviewed Nov 3, 2021
View reviewed changes
requirements-dev.txt Outdated
@@ -1,8 +1,9 @@
PyYAML<5.1 # pre-commit 0.8.0 doesnt support PyYAML>=6.0 and docker-compose 1.7.0 requires PyYAML<4,>=3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyYAML<4,>=3.10 but we ask for PyYAML<5.1 and docker-compose isn't in this requirements file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed PyYAML version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose is defined in tox.ini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to upgrade docker-compose and not be stuck with such an old version of PyYAML, but let's move forward for now.

@amribr amribr force-pushed the u/amribrahim/fix-build-failing branch from faef13a to 585150e Compare November 3, 2021 13:20
@JayH5
Copy link
Contributor

JayH5 commented Nov 3, 2021

I'm a bit confused as to why this build passed? #273

@amribr
Copy link
Contributor Author

amribr commented Nov 4, 2021 •
edited
Loading

@JayH5
It's probably because we don't install docker-compose or pre-commit except in the testenv via tox and requirement-dev.
At this step, PyYAML(6.0) get installed by pre-commit (nested dependency), which actually breaks pre-commit and cause explicit dependency conflict when tox tries installing docker-compose.

@amribr amribr merged commit d4f73e0 into master Nov 4, 2021
@amribr amribr added the dependencies Pull requests that update a dependency file label Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JayH5 JayH5 JayH5 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amribr @JayH5