Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure export classes #23

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

k0t3n
Copy link
Contributor

@k0t3n k0t3n commented Jul 16, 2024

Fix mypy warning

client/cache/memory.py:4: error: Module "theine" does not explicitly export attribute "Cache"  [attr-defined]

by explicitly defining export classes.

@k0t3n
Copy link
Contributor Author

k0t3n commented Jul 16, 2024

@Yiling-J btw thank for the library, great job.

@Yiling-J
Copy link
Owner

@k0t3n
I conducted a simple test by creating a file and running mypy:

from theine import *
from theine import Cache

It didn't report any issues. Since I haven't used Python recently and I'm not familiar with mypy, could you please share how to reproduce the warning?

@k0t3n
Copy link
Contributor Author

k0t3n commented Jul 17, 2024

@Yiling-J

from theine import Cache
mypy example.py --strict

@Yiling-J Yiling-J merged commit add711b into Yiling-J:main Jul 17, 2024
5 checks passed
@Yiling-J
Copy link
Owner

@k0t3n v0.4.2 released

@k0t3n
Copy link
Contributor Author

k0t3n commented Jul 17, 2024

Thank you, that was fast 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants