Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, readme rewrite #136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheArcaneBrony
Copy link

@TheArcaneBrony TheArcaneBrony commented Nov 24, 2022

Tiny refactor:

  • Remove dependency on konsole
  • Remove dependency on sudo
  • Rewrite and clarify readme

Resolves, aka carefully vetted list of affected issues:

Signed-off-by: TheArcaneBrony [email protected]

@TheArcaneBrony TheArcaneBrony changed the title Refactor Refactor, readme rewrite Nov 24, 2022
@Ritul13
Copy link

Ritul13 commented Feb 18, 2023

Bro i have arch linux how can i get your file which can be used please help me

@pnut8
Copy link

pnut8 commented Feb 23, 2023

Thanks @TheArcaneBrony , i was able to get this working on my system (msi gf63, pop os). The new write_EC.py file was giving me errors so i replaced it with original write_EC.py file (from @YoCodingMonster ). And few tweaks to conf.txt was needed for the Advanced window to pop up. 😇

@TheArcaneBrony
Copy link
Author

Could you tell me what errors you were having, and what Python version your system is running?

@pnut8
Copy link

pnut8 commented Feb 28, 2023

Could you tell me what errors you were having, and what Python version your system is running?

sudo python indicator.py
Traceback (most recent call last):
  File "/home/user/Downloads/OpenFreezeCenter-main/write_EC.py", line 49, in <module>
    vr = get_temp_list(5)
  File "/home/user/Downloads/OpenFreezeCenter-main/write_EC.py", line 45, in get_temp_list
    vr.append(int(i))
ValueError: invalid literal for int() with base 10: '3C'
  • note: i didn't install any special dependencies for this in my system.
  • Python 3.10.6

still it was functioning aside from 'Advanced' window (nothing happens when i click on it).

so i changed conf.txt file from this
Screenshot from 2023-02-28 13-30-53
to this
Screenshot from 2023-02-28 13-32-13

mainly just replaced non-integers in the 5th line of conf.txt file . After this 'Advanced' window started to function, but when i click Apply button on 'Advanced' window it freeze . And 'indicator.py' does not launch unless i press (ctrl + c) two times after changing conf.txt file.

errors after changing the conf.txt file

  sudo python indicator.py
  ^C^CTraceback (most recent call last):
    File "/home/user/Downloads/OpenFreezeCenter-main/write_EC.py", line 27, in write_EC
      file.seek(114)
  KeyboardInterrupt
  
  During handling of the above exception, another exception occurred:
  
  Traceback (most recent call last):
    File "/home/user/Downloads/OpenFreezeCenter-main/write_EC.py", line 66, in <module>
      write_EC(vr, battery_threshold)
    File "/home/user/Downloads/OpenFreezeCenter-main/write_EC.py", line 16, in write_EC
      with open(EC_IO_FILE, 'r+b') as file:
  KeyboardInterrupt

then i replaced it with old 'write_EC.py' . and everything started to function perfectly(when i ran it as superuser).
when i run it without superuser permission it gives me permission denied errors but it works .

sorry of being late and my English

@YoCodingMonster YoCodingMonster marked this pull request as ready for review February 28, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment