REDIS_ADDR should always be used for master/slave connections

[jhitt25]

ANNOUNCE_ADDR should be used as the address consul reports to clients.
REDIS_ADDR should always be used internally for SLAVEOF operations.

[jhitt25]

We use stunnel to encrypt our redis server-to-server connections. We want to make a standard address publicly accessible, but redis itself must communicate over a localhost address. Using ANNOUNCE_ADDR as the master address handily breaks this setup.

This setup will use REDIS_ADDR in the service ID, while still using ANNOUNCE_ADDR for the service address and port.

[jippi]

I need to review this carefully later, probably won't be for a couple of weeks due to work priorities.

It would be great to have teats to support the changes to avoid regressions :)

[jhitt25]

Agreed. I'm not a Go developer by trade, but i'll see what i can glean from the project setup. :)
I'll be out for a few weeks myself, but i figured it was worth getting a patch started.