Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local projects to use git_blacklist.ignore_patterns configuration #24

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Allow local projects to use git_blacklist.ignore_patterns configuration #24

merged 1 commit into from
Dec 18, 2023

Conversation

Anve94
Copy link
Member

@Anve94 Anve94 commented Dec 18, 2023

No description provided.

@igorwulff
Copy link
Member

@Anve94 Is there anything you think we should add to the extend git blacklist: https://github.com/YouweGit/testing-suite/blob/master/config/magento2/grumphp.yml

@igorwulff
Copy link
Member

@Anve94 there seems to be issues with the Unit Test... We might have to migrate them:
@github-actions
Testing Suite / PHP (srcoder/development-php:php74-fpm) (push) Failing after 26s
Details
@github-actions
Testing Suite / PHP (srcoder/development-php:php80-fpm) (push) Failing after 31s
Details
@github-actions
Testing Suite / PHP (srcoder/development-php:php81-fpm) (push) Failing after 32s
Details

@igorwulff igorwulff merged commit df7693a into master Dec 18, 2023
0 of 3 checks passed
@igorwulff igorwulff deleted the improvement/git-blacklist-ignore-patterns branch December 18, 2023 09:37
@Anve94
Copy link
Member Author

Anve94 commented Dec 18, 2023

@igorwulff We already made some updates to the blacklist patterns earlier.
Related to the actions: I expect these are affected by the same issue as this one: #19

I'll add a comment to that issue to also include a test refactor to the scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuckThom DuckThom DuckThom approved these changes

@igorwulff igorwulff igorwulff approved these changes

@fredden fredden Awaiting requested review from fredden

@rutgerrademaker rutgerrademaker Awaiting requested review from rutgerrademaker

@Epo123 Epo123 Awaiting requested review from Epo123

@arnoudhgz arnoudhgz Awaiting requested review from arnoudhgz

@viniciusfabri viniciusfabri Awaiting requested review from viniciusfabri

@leonhelmus leonhelmus Awaiting requested review from leonhelmus

@kjkooistra-youwe kjkooistra-youwe Awaiting requested review from kjkooistra-youwe

@youwe-petervanderwal youwe-petervanderwal Awaiting requested review from youwe-petervanderwal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anve94 @igorwulff @DuckThom