-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Supports enumerating Ed25519 and P521 credentials within FIDO #186
Conversation
CoseEcPublicKey.cs now handles P384 and P521 CoseEdDsaPublicKey.cs adds support for Ed25519
Test Results: Windows 2 files 2 suites 5s ⏱️ Results for commit 9d37340. ♻️ This comment has been updated with latest results. |
Test Results: Ubuntu 2 files 2 suites 9s ⏱️ Results for commit 9d37340. ♻️ This comment has been updated with latest results. |
Test Results: MacOS 2 files 2 suites 5s ⏱️ Results for commit 9d37340. ♻️ This comment has been updated with latest results. |
supports P384 and P521 keys.
…tency, added tests
…type enumerations
…nd improve test descriptions
…estDeviceEnumeration
…t curve retrieval logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things, also add tests on CoseEdDsaPublicKey
Yubico.YubiKey/src/Yubico/YubiKey/Fido2/Cose/CoseEdDsaPublicKey.cs
Outdated
Show resolved
Hide resolved
Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/EcdsaVerifyTests.cs
Outdated
Show resolved
Hide resolved
Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/EcdsaVerifyTests.cs
Outdated
Show resolved
Hide resolved
Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/IntegrationTestDeviceEnumeration.cs
Outdated
Show resolved
Hide resolved
Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/IntegrationTestDeviceEnumeration.cs
Outdated
Show resolved
Hide resolved
Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/IntegrationTestDeviceEnumeration.cs
Outdated
Show resolved
Hide resolved
Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/IntegrationTestDeviceEnumeration.cs
Outdated
Show resolved
Hide resolved
…aPublicKey documentation; rename test classes and methods for clarity
Yubico.YubiKey/src/Yubico/YubiKey/Fido2/Cose/CoseEcPublicKey.cs
Outdated
Show resolved
Hide resolved
Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/EcdsaVerifyTests.cs
Outdated
Show resolved
Hide resolved
Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/EcdsaVerifyTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have one question regarding the Cbor output. See above comment
Yubico.YubiKey/tests/unit/Yubico/YubiKey/Fido2/Cose/CoseEdDsaPublicKeyTests.cs
Outdated
Show resolved
Hide resolved
…nstead of hardcoded constant; improve clarity in CoseEdDsaPublicKeyTests
This pull request includes adds support for Ed25519 FIDO credentials and updates to the
EcdsaVerify
class within theYubico.YubiKey.Cryptography
namespace to enhance its flexibility and maintainability. The changes primarily focus on extending the supported elliptic curves, refactoring the code for better readability, and improving error handling.Will also fix this: virot/powershellYK#86
Key updates include:
Support for Additional Curves
Refactoring and Code Simplification
GetOidByAlgorithm
andGetOidByLength
methods to streamline the process of obtaining OIDs based on algorithm identifiers and encoded point lengths, respectively. [1] [2]KeyDefinitions
. [1] [2]Error Handling Improvements
Documentation Updates
Code Cleanup
These changes collectively enhance the functionality and maintainability of the
EcdsaVerify
class, ensuring it can handle a wider range of elliptic curve signatures with improved clarity and robustness.