Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request microphone permission when recording video #808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Request microphone permission when recording video #808

wants to merge 1 commit into from

Commits on Dec 19, 2023

  1. Request microphone permission when recording video 

    YPVideoCaptureHelper supports capturing audio, but YPImagePicker does
not request microphone permission.  As a result, videos silently fail to
include audio unless the client app preemptively requests audio
permission prior to opening YPImagePicker.

In contrast, YPImagePicker does request photo library permission (in
YPLibraryVC) and camera permission (in YPCameraVC and YPVideoCaptureVC).
With this change, YPVideoCaptureVC also requests microphone permission,
standardizing YPImagePicker's behavior across the three permissions.
    @u2606
    u2606 committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    bb861d4 View commit details
    Browse the repository at this point in the history