Manage oldstable version

config_panel.toml

@@ -16,6 +16,14 @@ name = "Nextcloud configuration"
         type = "button"
         style = "success"
 
+    [main.version]
+        [main.version.version_to_follow]
+        ask.en = "Upgrade channel to use"
+        type = "select"
+        choices = ["stable", "oldstable"]
+        default = "stable"
+        help.en = "Recent major releases contains sometimes some annoying bugs or regressions. Using the oldstable channel during this period can be useful if you need high stability."
+
     [main.addressbook]
     name = "Address book configuration"
 

manifest.toml

@@ -60,6 +60,13 @@ ram.runtime = "512M"
     type = "boolean"
     default = true
 
+    [install.version_to_follow]
+    ask.en = "Upgrade channel to use"
+    help.en = "Recent major releases contains sometimes some annoying bugs or regressions. Using the oldstable channel during this period can be useful if you need high stability."
+    type = "select"
+    choices = ["stable", "oldstable"]
+    default = "stable"
+
     [install.enable_notify_push]
     ask.en = "Configure the High Performance Backend?"
     ask.fr = "Configurer le Backend Hautes Performances ?"
@@ -68,6 +75,7 @@ ram.runtime = "512M"
     help.en = "Also called 'notify push' and corresponds to a mechanism allowing more instantaneous notifications and reduce server load. (However, it is still a bit new and adds complexity to the setup)"
     help.fr = "Aussi appelé 'notifications push' et corresponds à un mécanisme qui permet d'avoir des notifications plus rapides et de réduire la charge du serveur. (Cependant, cette fonctionnalité reste relativement nouvelle, et augmente la complexité de l'installation)"
 
+
 [resources]
 
     [resources.sources]

scripts/install

@@ -23,8 +23,15 @@ ynh_script_progression --message="Setting up source files..." --weight=5
 
 # Enable YunoHost patches on Nextcloud sources
 cp -a ../sources/patches_last_version/* ../sources/patches
+
+source_id="main"
+if [ "$version_to_follow" == "oldstable" ]; then
+    last_version=$(ynh_read_manifest --manifest_key="resources.sources.main.url" | grep -o '[0-9][0-9]\.[0-9]\.[0-9]')
+    last_major_version=${last_version%%.*}
+    last_major_version=$(( $last_major_version - 1 ))
+fi
 # Download, check integrity, uncompress and patch the source from app.src
-ynh_setup_source --dest_dir="$install_dir"
+ynh_setup_source --dest_dir="$install_dir" --source_id="$source_id"
 
 #=================================================
 # PHP-FPM CONFIGURATION

scripts/upgrade

@@ -40,6 +40,13 @@ then
     ynh_die --message="Upgrading from Nextcloud < 22.2 is not supported anymore. You should first upgrade to 22.2 using: yunohost app upgrade nextcloud -u https://github.com/YunoHost-Apps/nextcloud_ynh/tree/41f5f902e7c7cd3c30a6793020562ba98b9bf3e9"
 fi
 
+if [ -z "${version_to_follow:-}" ]
+then
+    version_to_follow=stable
+    ynh_app_setting_set --app=$app --key=version_to_follow --value="$version_to_follow"
+fi
+
+
 #=================================================
 # SPECIFIC UPGRADE
 #=================================================
@@ -128,6 +135,11 @@ current_major_version=${current_version%%.*}
 
 last_version=$(ynh_read_manifest --manifest_key="resources.sources.main.url" | grep -o '[0-9][0-9]\.[0-9]\.[0-9]')
 last_major_version=${last_version%%.*}
+if [[ "$version_to_follow" == "oldstable" ]]
+then
+    last_major_version=$(( $last_major_version - 1 ))
+    last_version=$(ynh_read_manifest --manifest_key="resources.sources.${last_major_version}.url" | grep -o '[0-9][0-9]\.[0-9]\.[0-9]')
+fi
 
 if [[ "$last_major_version" != "$current_major_version" ]]
 then
@@ -169,17 +181,19 @@ then
     fi
 
     # While the current version is not the last version, do an upgrade
-    while [ "$last_version" != "$current_version" ]
+    while [[ "$last_version" > "$current_version" ]]
     do
-
         next_major_version="$(( $current_major_version + 1 ))"
+        source_id="$next_major_version"
         if [[ "$next_major_version" -ge "$last_major_version" ]]; then
             ynh_print_info --message="Upgrading to Nextcloud $last_version"
             cp -a ../sources/patches_last_version/* ../sources/patches
-            source_id="main"
+            if [[ "$version_to_follow" != "oldstable" ]]
+            then
+                source_id="main"
+            fi
         else
             ynh_print_info --message="Upgrading to Nextcloud $next_major_version"
-            source_id="$next_major_version"
         fi
 
         # Create a temporary directory

tests.toml

@@ -2,6 +2,7 @@ test_format = 1.0
 
 [default]
 
+    args.version_to_follow = "stable"
     args.enable_notify_push = "0"
 
     # -------------------------------
@@ -38,8 +39,12 @@ test_format = 1.0
     caldav.logged_on_sso = true
     caldav.expect_content = "This is the WebDAV interface."
 
+[oldstable]
+    args.version_to_follow = "oldstable"
+    test_upgrade_from.e9f82ab7.name = "Upgrade from 28.0.6"
+    test_upgrade_from.e9f82ab7.args.system_addressbook_exposed = "yes"
+
 [notify_push_test]
-
     args.enable_notify_push = "1"
     test_upgrade_from.e9f82ab7.name = "Upgrade from 28.0.6"
-    test_upgrade_from.e9f82ab7.args.system_addressbook_exposed = "yes"
+    test_upgrade_from.e9f82ab7.args.system_addressbook_exposed = "yes"