Add swap #102
Closed
Add swap #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexAubin
reviewed
Jan 3, 2021
Comment on lines
+57
to
+69
| total_memory=$(ynh_get_ram --total) | ||
| total_swap=$(ynh_get_ram --total --only_swap) | ||
| swap_needed=0 | ||
|
|
||
| if [ $total_memory -lt 4096 ]; then | ||
| # Need a minimum of 4GB of memory | ||
| swap_needed=$((4096 - $total_memory)) | ||
| fi | ||
|
|
||
| # Need at least 2GB of swap | ||
| if [ $(($total_swap + $swap_needed)) -lt 2048 ]; then | ||
| swap_needed=$((2048 - $total_swap)) | ||
| fi |
There was a problem hiding this comment.
Out of curiosity, did you try using ynh_require_ram for this ? Or was it not matching what you aim to want to do ? Can you elaborate on this ? (So that maybe we can improve the official helper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
ynh_add_swapPR Status
Validation
Minor decision