test_shader_2d_primitives in CI + small fixes #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only working on CEF/Zapium before.
By removing the 0.5 pixel offset that we only did in the JS version. And by offsetting the grid itself a bit so it looks better.
janpaul123
force-pushed
the
fix-2d-rendering-blurring
branch
from
eb48775 to
b264117
Compare
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to fix some rounding issues in 2d rendering, but I didn't manage to actually fix them. (See this live stream.) I did make some more general improvements though, so let's check those in. I ticketed the remaining work in #181.
See individual commits!