frost-core: expose SigningKey::to/from_scalar() (#601)

* frost-core: expose SigningKey::to/from_scalar() * Update frost-core/CHANGELOG.md
ZcashFoundation · Feb 1, 2024 · 2f01e01 · 2f01e01
1 parent e1fb9bc
commit 2f01e01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/frost-core/CHANGELOG.md b/frost-core/CHANGELOG.md
@@ -4,6 +4,8 @@ Entries are listed in reverse chronological order.
 
 ## Unreleased
 
+* Exposed the `SigningKey::from_scalar()` and `to_scalar()` methods. This
+  helps interoperability with other implementations.
 
 ## Released
 

diff --git a/frost-core/src/signing_key.rs b/frost-core/src/signing_key.rs
@@ -58,15 +58,13 @@ where
     }
 
     /// Creates a SigningKey from a scalar.
-    #[cfg(feature = "internals")]
     pub fn from_scalar(
         scalar: <<<C as Ciphersuite>::Group as Group>::Field as Field>::Scalar,
     ) -> Self {
         Self { scalar }
     }
 
     /// Return the underlying scalar.
-    #[cfg(feature = "internals")]
     pub fn to_scalar(self) -> <<<C as Ciphersuite>::Group as Group>::Field as Field>::Scalar {
         self.scalar
     }