Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve book per audit report #491

Merged
merged 5 commits into from
Sep 5, 2023
Merged

improve book per audit report #491

merged 5 commits into from
Sep 5, 2023

Conversation

conradoplg
Copy link
Contributor

@conradoplg conradoplg commented Aug 19, 2023

Closes #466

I split the tutorial into multiple subsections to make the structure less confusing. This will make the edits harder to see - sorry. Try using git diff --color-moved origin/main.

@github-actions
Copy link

github-actions bot commented Aug 19, 2023

Visit the preview URL for this PR (updated for commit 6c53eb1):

https://frost-book--pr491-improve-book-audit-7ggit0pm.web.app

(expires Tue, 19 Sep 2023 00:05:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09% 🎉

Comparison is base (60d9942) 77.46% compared to head (98155d3) 77.56%.
Report is 16 commits behind head on main.

❗ Current head 98155d3 differs from pull request most recent head 6c53eb1. Consider uploading reports for the commit 6c53eb1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   77.46%   77.56%   +0.09%     
==========================================
  Files          30       30              
  Lines        2738     2763      +25     
==========================================
+ Hits         2121     2143      +22     
- Misses        617      620       +3     

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dconnolly
dconnolly previously approved these changes Sep 5, 2023
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mergify bot added a commit that referenced this pull request Sep 5, 2023
@mergify mergify bot merged commit d439fdc into main Sep 5, 2023
15 checks passed
@mergify mergify bot deleted the improve-book-audit branch September 5, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve FROST book per audit report
2 participants