Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return error when creating a zero SigningKey #496

Merged
merged 3 commits into from
Sep 2, 2023
Merged

Conversation

conradoplg
Copy link
Contributor

Closes #465

Since VerifyingKey::new() is private, it shouldn't possible to create one from identity, so this addresses the whole issue.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (60d9942) 77.46% compared to head (f8a9197) 77.48%.
Report is 5 commits behind head on main.

❗ Current head f8a9197 differs from pull request most recent head f0bd8fc. Consider uploading reports for the commit f0bd8fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   77.46%   77.48%   +0.02%     
==========================================
  Files          30       30              
  Lines        2738     2741       +3     
==========================================
+ Hits         2121     2124       +3     
  Misses        617      617              
Files Changed Coverage Δ
frost-core/src/signing_key.rs 76.00% <100.00%> (+1.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpguerra mpguerra mentioned this pull request Aug 23, 2023
26 tasks
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

mergify bot added a commit that referenced this pull request Sep 2, 2023
@mergify mergify bot merged commit 5cd3f8f into main Sep 2, 2023
@mergify mergify bot deleted the handle-zero-key branch September 2, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of identity/zero in VerifyingKey/SigningKey
2 participants