Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document features #512

Merged
merged 1 commit into from
Sep 4, 2023
Merged

document features #512

merged 1 commit into from
Sep 4, 2023

Conversation

conradoplg
Copy link
Contributor

Depends on #492

  • Document features (serde and internals for now, but also can be used for serialization if add default serialization format #511 merges) using document-features crate
  • Enable flags to show features required to enable specific types in the docs

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (f3eb868) 77.48% compared to head (9b39ab7) 77.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   77.48%   77.56%   +0.07%     
==========================================
  Files          30       30              
  Lines        2754     2763       +9     
==========================================
+ Hits         2134     2143       +9     
  Misses        620      620              
Files Changed Coverage Δ
frost-ed25519/src/lib.rs 64.06% <ø> (ø)
frost-ed448/src/lib.rs 64.06% <ø> (ø)
frost-p256/src/lib.rs 68.27% <ø> (ø)
frost-secp256k1/src/lib.rs 68.05% <ø> (ø)
frost-core/src/frost.rs 91.79% <100.00%> (+0.15%) ⬆️
frost-core/src/frost/round1.rs 87.11% <100.00%> (+0.07%) ⬆️
frost-core/src/frost/round2.rs 91.11% <100.00%> (+0.20%) ⬆️
frost-core/src/lib.rs 58.49% <100.00%> (+0.79%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dconnolly
dconnolly previously approved these changes Sep 2, 2023
Base automatically changed from fix-unneeded-deps to main September 2, 2023 05:01
@mergify mergify bot dismissed dconnolly’s stale review September 2, 2023 05:01

The base branch was changed.

@conradoplg
Copy link
Contributor Author

Rebased after base branch was merged, needs reapproval

mergify bot added a commit that referenced this pull request Sep 4, 2023
@mergify mergify bot merged commit 4abe7fe into main Sep 4, 2023
15 checks passed
@mergify mergify bot deleted the document-features branch September 4, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants