Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fields to match types #539

Merged
merged 9 commits into from
Sep 15, 2023
Merged

Rename fields to match types #539

merged 9 commits into from
Sep 15, 2023

Conversation

natalieesk
Copy link
Contributor

This closes #495

  1. Updated SecretShare, Package and KeyPackage fields to use signing_share
  2. Updated PublicKeyPackage to use verifying_shares
  3. Updated KeyPackage to use verifying_key
  4. Removed secret() from SecretShare

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Visit the preview URL for this PR (updated for commit 0356cab):

https://frost-book--pr539-rename-fields-495-u6jnwgxu.web.app

(expires Fri, 29 Sep 2023 13:28:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (c38305b) 81.18% compared to head (0356cab) 81.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   81.18%   81.17%   -0.02%     
==========================================
  Files          30       30              
  Lines        3014     3012       -2     
==========================================
- Hits         2447     2445       -2     
  Misses        567      567              
Files Changed Coverage Δ
frost-core/src/frost.rs 92.36% <100.00%> (ø)
frost-core/src/frost/keys.rs 98.42% <100.00%> (-0.02%) ⬇️
frost-core/src/frost/keys/dkg.rs 89.13% <100.00%> (+0.04%) ⬆️
frost-core/src/frost/keys/repairable.rs 97.14% <100.00%> (ø)
frost-core/src/frost/round2.rs 100.00% <100.00%> (ø)
frost-rerandomized/src/lib.rs 83.62% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

Could you please add a CHANGELOG entry for this, listing the old and new names, e.g. "SecretShare::value()" was changed to SecretShare::signing_share()"?

I'm approving this so it will get merged soon, to unblock other work, you can do that in a separate PR if it's OK.

@mergify mergify bot merged commit eee505a into main Sep 15, 2023
@mergify mergify bot deleted the rename_fields_495 branch September 15, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename fields to match types
2 participants