-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fields to match types #539
Conversation
Some naming needed to be updated in DKG as well as there was already a verifying_key which was actually a verifying_share
This is because we now can use the getter to get signing_share() without the need for an additional function
Visit the preview URL for this PR (updated for commit 0356cab): https://frost-book--pr539-rename-fields-495-u6jnwgxu.web.app (expires Fri, 29 Sep 2023 13:28:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 81.18% 81.17% -0.02%
==========================================
Files 30 30
Lines 3014 3012 -2
==========================================
- Hits 2447 2445 -2
Misses 567 567
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
Could you please add a CHANGELOG entry for this, listing the old and new names, e.g. "SecretShare::value()" was changed to SecretShare::signing_share()"?
I'm approving this so it will get merged soon, to unblock other work, you can do that in a separate PR if it's OK.
This closes #495