Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #578

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Fix warnings #578

merged 3 commits into from
Nov 16, 2023

Conversation

natalieesk
Copy link
Contributor

This closes #576

Fixes publishing warnings for release v1.0.0-rc.0

Copy link

Visit the preview URL for this PR (updated for commit 1e2d1fc):

https://frost-book--pr578-fix-warnings-576-o0w50dkr.web.app

(expires Thu, 30 Nov 2023 16:23:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37e8856) 81.94% compared to head (1e2d1fc) 82.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   81.94%   82.02%   +0.08%     
==========================================
  Files          31       31              
  Lines        3151     3143       -8     
==========================================
- Hits         2582     2578       -4     
+ Misses        569      565       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

mergify bot added a commit that referenced this pull request Nov 16, 2023
@mergify mergify bot merged commit 036b0ce into main Nov 16, 2023
17 checks passed
@mergify mergify bot deleted the fix_warnings_576 branch November 16, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix warnings for BindingFactor, BindingFactorList and SigningShare functions
2 participants