return error when deserializing the identity #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
force-pushed
the
deserialize-error-on-identity
branch
2 times, most recently
from
e70a5a7 to
a52e04e
Compare
conradoplg
force-pushed
the
deserialize-error-on-identity
branch
from
a52e04e to
179347a
Compare
conradoplg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #667
To keep serde working, I switched to another approach which is actually much simpler. Instead of using
serde(try_from/into)(which I no longer couldn't since there is notry_into) I simply created aSerializedElementtype which does define serde encoding and used it in place of a rawElement. This allows the struct that contains it to support serde by simply deriving it. It does introduce some friction by requiring using e.g.val.0 .0but that's internal (and can be avoided with getters). We should probably use the same approach for Scalars, but we can do that in a separate PR.