Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh Shares with DKG #766

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Refresh Shares with DKG #766

merged 5 commits into from
Dec 11, 2024

Conversation

natalieesk
Copy link
Contributor

@natalieesk natalieesk commented Nov 8, 2024 •
edited
Loading

This closes #663

This adds the refresh share functionality with DKG. It needs some tidying up but that will be done in another PR.

@natalieesk natalieesk linked an issue Nov 8, 2024 that may be closed by this pull request
Feature: Remove signers or refresh shares with DKG #663
Closed
conradoplg
conradoplg approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. I added a couple of comments, feel free to mark them as solved and address them in the refactoring PR if you prefer to.

mergify bot added a commit that referenced this pull request Dec 11, 2024
@mergify
Merge of #766
21567a4
@mergify mergify bot mentioned this pull request Dec 11, 2024
Closed
10 tasks
@mergify mergify bot merged commit dee685d into main Dec 11, 2024
19 checks passed
@mergify mergify bot deleted the refresh_shares_dkg_663 branch December 11, 2024 08:57
@StackOverflowExcept1on StackOverflowExcept1on mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Remove signers or refresh shares with DKG
2 participants
@natalieesk @conradoplg