Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for all test vectors in DKG #875

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

azuchi
Copy link
Contributor

@azuchi azuchi commented Feb 16, 2025

The current DKG test vector is only tested on participant 1's data. This PR applies the same tests to the data from participants 2 and 3.

Accordingly, the following modifications were made to the existing Test Vector:

frost-ed448

Fix incorrect share generated from polynomials.

frost-ed25519

Fix incorrect shares generated in roud2, step3.

frost-secp256k1-tr

  • Fix incorrect proof_of_knowledge for participant 1.
  • Add missing data for participants 2 and 3.

If I have misunderstood these test vector modifications, please let me know.

@mpguerra mpguerra requested a review from conradoplg February 17, 2025 08:17
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.88%. Comparing base (5f4ac6e) to head (1e5069a).
Report is 103 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   82.18%   82.88%   +0.69%     
==========================================
  Files          31       41      +10     
  Lines        3188     4387    +1199     
==========================================
+ Hits         2620     3636    +1016     
- Misses        568      751     +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant