Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): use newer method to set an output parameter #6039

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

gustavovalverde
Copy link
Member

Motivation

The set-output command is deprecated and will be disabled soon.
For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Fixes #5736

Specifications

Solution

Apply the method used in the specifications.

Review

Anyone can review this

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ I-integration-fail Continuous integration fails, including build and test failures labels Jan 27, 2023
@gustavovalverde gustavovalverde self-assigned this Jan 27, 2023
@gustavovalverde gustavovalverde requested a review from a team as a code owner January 27, 2023 02:16
@gustavovalverde gustavovalverde requested review from teor2345 and removed request for a team January 27, 2023 02:16
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jan 27, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing some set-output warnings, maybe they are from actions we are using? Do we need a separate ticket to upgrade those actions before May?
https://github.com/ZcashFoundation/zebra/actions/runs/4020943497
https://github.com/ZcashFoundation/zebra/actions/runs/4020943505

There were also some errors in release drafter, but they seem to be unrelated to these changes.

@gustavovalverde
Copy link
Member Author

@teor2345 I just fixed the replacements I made by mistake.

About the remaining errors, I created a ticket for that:

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks great!

mergify bot added a commit that referenced this pull request Jan 31, 2023
@mergify mergify bot merged commit 333b5ea into main Jan 31, 2023
@mergify mergify bot deleted the fix-workflow-outputs branch January 31, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change(ci): Change set-output to environment files by May 2023
2 participants