Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(ci): Delete least used ci-build-crates.yml step and increase concurrency #8058

Merged
merged 1 commit into from
Dec 6, 2023
Merged

change(ci): Delete least used ci-build-crates.yml step and increase concurrency #8058

merged 1 commit into from
Dec 6, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Dec 5, 2023

Motivation

Currently building crates individually is the longest workflow, so let's reduce the time it takes.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

  • Remove the step that tests the least common configuration
  • Increase concurrency from 3 to 4

Testing

This slightly reduces build coverage, but the removed settings are unusual.

Review

This is a low priority change/cleanup.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 5, 2023
@teor2345 teor2345 self-assigned this Dec 5, 2023
@teor2345 teor2345 requested a review from a team as a code owner December 5, 2023 22:30
@teor2345 teor2345 requested review from upbqdn and removed request for a team December 5, 2023 22:30
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Dec 5, 2023
@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Dec 5, 2023
@teor2345 teor2345 changed the title change(ci): Remove least used ci-build-crates.yml step and increase concurrency change(ci): Delete least used ci-build-crates.yml step and increase concurrency Dec 5, 2023
@teor2345
Copy link
Contributor Author

teor2345 commented Dec 5, 2023

Oops I said "Remove" so it got labelled as extra-reviews.

mergify bot added a commit that referenced this pull request Dec 6, 2023
@mergify
Merge of #8058
ffcf08a
@mergify mergify bot mentioned this pull request Dec 6, 2023
Closed
@mergify mergify bot merged commit 73b3ed1 into main Dec 6, 2023
93 checks passed
@mergify mergify bot deleted the tweak-crates branch December 6, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

Assignees

@teor2345 teor2345

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @upbqdn