-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(scan): Add the scan_start_where_left
test to CI
#8172
Conversation
Let's see if the new job actually runs in the CI. |
a166a8c
to
147ca1e
Compare
147ca1e
to
0ba1e63
Compare
Co-authored-by: Arya <[email protected]>
@arya2 thanks for the fix! I looked at our Dockerfile, and I noticed we build the test binaries when building the image: https://github.com/zcashfoundation/zebra/blob/88dd18adb7db6e6127da578d9d7aaa7cab869fe9/docker/Dockerfile#L133-L134. The new job in this PR runs the tests here https://github.com/zcashfoundation/zebra/blob/88dd18adb7db6e6127da578d9d7aaa7cab869fe9/docker/entrypoint.sh#L183 with a different set of features. That means the tests are rebuilt each time the job runs anyway. I wonder if we could omit building the tests in the Dockerfile. Edit: The answer is no because only a small subset of the crates is recompiled. If we omitted the building in the Dockerfile, each job would need to rebuild all of the crates. |
Motivation
Close #8085.
PR Author Checklist
Check before marking the PR as ready for review:
Solution
scan-start-where-left-test
to the Integration Tests on GCP workflow.Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.