Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_gazebo: add casters to fetch.gazebo.xacro #49

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

moriarty
Copy link
Contributor

@moriarty moriarty commented Mar 22, 2019

This adds 4 casters to the gazebo model, and updates the physics params.

This should fix #31 or at least make it better. It should also fix #35. This is related to #37.

I launched this twice and it grasped the cube both times, so it's much better than it was.
But the values still need further tuning for navigation, and e.g. #30

This adds 4 casters to the gazebo model, and updates the physics params.

This should fix ZebraDevs#31.

This is related to ZebraDevs#37
<visual>
<origin rpy="0 0 0" xyz="0 0 0"/>
<geometry>
<sphere radius="0.0601"/> <!-- 0.06033 -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value in comments, 0.06033 is the actual value of the wheel, but I've made the caster slightly smaller.

When the values were all the same as the wheel, the wheels did not have enough contact with the ground.

@moriarty
Copy link
Contributor Author

@narora1 & @fetchrobotics/opensource I've setup the repo so that pull requests now need to be approved.

Before: https://youtu.be/FyyGwdU6qRE
After: https://youtu.be/5u44H43ArdQ

@moriarty moriarty requested review from velveteenrobot and cjds March 24, 2019 23:35
Copy link
Contributor

@RDaneelOlivav RDaneelOlivav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form my point of view , the base moves much smoother. Adding casters was something absolutely vital, specially in robots with two wheel movement. The old way of using the base collision element as caster wheels is unacceptable now a days. I aprove this changes for sure ;).

@moriarty moriarty merged commit 20bf7c8 into ZebraDevs:gazebo9 Mar 25, 2019
@umhan35
Copy link

umhan35 commented Jun 5, 2019

@moriarty @RDaneelOlivav Do we plan to backport this to Gazebo 7? I know that Kinetic is not officially supported but we do actually publish the gazebo 7 version of the simulation...

@moriarty
Copy link
Contributor Author

moriarty commented Jun 5, 2019

I thought I back-ported everything that needed back porting...

@umhan35 I'll be on vacation until next week, next week I'll double check all the open source issues and see if this change is needed.

@umhan35
Copy link

umhan35 commented Jun 5, 2019

@moriarty Thanks. I double checked the last change to fetch.gazebo.xacro in gazebo7 branch is 2015. https://github.com/fetchrobotics/fetch_gazebo/blob/gazebo7/fetch_gazebo/robots/fetch.gazebo.xacro

This is a low prority though. It just happens that our interns are using kinetic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Regression in simulated Fetch robot (Melodic, Gazebo 9) [pick_place_demo.py] cannot grasp the cube
3 participants